Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rendered avatar size #318

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Change rendered avatar size #318

merged 2 commits into from
Sep 26, 2024

Conversation

pkevan
Copy link
Contributor

@pkevan pkevan commented Sep 13, 2024

Reduces the standard fetched avatar size, dependant on the format.

Fixes #317.

Note: couldn't successfully build this to test locally.

Reduces the standard fetched avatar size, dependant on the format.
@ryelle
Copy link
Contributor

ryelle commented Sep 13, 2024

Good catch on the image size 🙂

The sizes are reversed here — the avatar should be 30px when truncated, and 70px when not.

Screenshot 2024-09-13 at 12 18 41 PM

Note: couldn't successfully build this to test locally.

I never updated the instructions, so they're probably not correct 😅

@ryelle
Copy link
Contributor

ryelle commented Sep 13, 2024

I just updated the directions in the readme, the biggest difference from other projects was that I'm trying out vanilla/modern npm, instead of the legacy yarn we've been using.

The new setup uses wp-env, but if you had something working with a different local env, you should be able to run these to get the new theme built and usable:

npm run setup:tools
npm run build:theme

@pkevan
Copy link
Contributor Author

pkevan commented Sep 26, 2024

The sizes are reversed here — the avatar should be 30px when truncated, and 70px when not.

OK - makes sense, got confused for a minute!

@pkevan pkevan merged commit 04e5480 into production Sep 26, 2024
2 checks passed
@pkevan pkevan deleted the fix/avatar-size branch September 26, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

New Theme: Use appropriately size gravatar images.
2 participants